Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mxnet #2146

Merged
merged 7 commits into from
Apr 1, 2025
Merged

remove mxnet #2146

merged 7 commits into from
Apr 1, 2025

Conversation

mengniwang95
Copy link
Contributor

Description

remove mxnet related code

Signed-off-by: Mengni Wang <[email protected]>
@mengniwang95
Copy link
Contributor Author

Not sure whether need to delete mxnet from third-party-programs.txt, please confirm @chensuyue

@mengniwang95 mengniwang95 requested review from XuehaoSun, chensuyue and thuang6 and removed request for XuehaoSun March 19, 2025 06:36
@chensuyue
Copy link
Contributor

Not sure whether need to delete mxnet from third-party-programs.txt, please confirm @chensuyue

Yes, can be deleted.

@mengniwang95
Copy link
Contributor Author

Not sure whether need to delete mxnet from third-party-programs.txt, please confirm @chensuyue

Yes, can be deleted.

I found there is some references,

https://github.com//apache/incubator-mxnet/blob/master/python/mxnet/contrib/quantization.py
, can mxnet be deleted from third-party-programs.txt?

@mengniwang95
Copy link
Contributor Author

the error is all about horovod setup and sigopt, seems not caused by this PR, could you help to check? @XuehaoSun

@XuehaoSun
Copy link
Contributor

the error is all about horovod setup and sigopt, seems not caused by this PR, could you help to check? @XuehaoSun

sure

@XuehaoSun
Copy link
Contributor

the error is all about horovod setup and sigopt, seems not caused by this PR, could you help to check? @XuehaoSun

horovod install fails because cmake==4.0.0, I will fix it.
But fails for "other babsic case test" due to AttributeError: type object 'TestSameTransfoms' has no attribute 'mx_trans', please fix it.
https://dev.azure.com/lpot-inc/neural-compressor/_build/results?buildId=38819&view=logs&j=14ffa4b7-00d4-5bb8-e6b8-60728ee82489&t=95fed235-93e7-57e2-cdbc-5f45d6538d7f&l=10432
image

@XuehaoSun XuehaoSun merged commit ff969bc into master Apr 1, 2025
33 checks passed
@XuehaoSun XuehaoSun deleted the mengni/mxnet branch April 1, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants