Skip to content

[SYCL] Optimize handler::setNDRangeDescriptor #17969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Optimize handler::setNDRangeDescriptor #17969

wants to merge 10 commits into from

Conversation

slawekptak
Copy link
Contributor

No description provided.

@slawekptak slawekptak marked this pull request as ready for review April 15, 2025 09:50
@slawekptak slawekptak requested a review from a team as a code owner April 15, 2025 09:50
steffenlarsen
steffenlarsen reviewed Apr 15, 2025
View reviewed changes
steffenlarsen
steffenlarsen approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aelovikov-intel
Copy link
Contributor

How much does this help? sizeof(range<N>) == N * sizeof(void *), so everything should be really fast (about as fast as std::string_view that has the size of two pointers, and nobody passes it by reference nor does reset magic wit it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov left review comments

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slawekptak @aelovikov-intel @sergey-semenov @steffenlarsen