-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][CI] Update workflow files to match sycl
branch
#17612
[SYCL][CI] Update workflow files to match sycl
branch
#17612
Conversation
This is an attempt to fix pre-commit on `sycl-rel-6_1_0` branch by updating all workflow files to make then in sync with `sycl` branch.
…chkov/refresh-ci-scripts
…chkov/refresh-ci-scripts
I took a look at Windows issues and it seems like all of them require some test tweaks for us to have a successful pre-commit. I don't want to include all those patches here to avoid overcomplicating the PR, but we should not consider failures on Windows to be blocking the merge.
|
Linux failures analysis:
I haven't investigated other failures yet, but I also expect them to be mostly caused by missing patches. Considering that the only thing this patch changes is the infrastructure, I think it is safe to merge it. As I said above, test tweaks to fix failures will be cherry-picked separately to reduce scope of the patches. |
@intel/sycl-matrix-reviewers, @intel/dpcpp-esimd-reviewers, FYI: you were summoned because I changed |
@AlexeySachkov I'm fine with dropping igc-dev from testing. The question though is - what drivers we recommend users to install for open source releases? |
I think that our recommendation is to always go for the latest one, because the interfaces should be stable and we are not allowed to break ABI. What we have been doing so far (and will continue doing so) is documenting which version we have tested against so that our customers know what we used as a "reference". See example in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming everything is a legit copy-paste from sycl
Those dockerfiles were previosly renamed on `sycl` branch in intel#16255 and intel#16680. When we synced `.github` and `devops` changes from `sycl` to `sycl-rel-6_1_0` in intel#17612, we copied over new versions, but did not delete the old ones and this PR does exactly that.
This is an attempt to fix pre-commit on
sycl-rel-6_1_0
branch by copying contents of CI scripts fromsycl
branch.This PR specifically ignores changes to upstream workflows, because we do not have them enabled at intel/llvm.