[SYCL][E2E] Update is_compatible tests #17606
Conversation
Due to incorrect REQUIRES these tests are never launched.
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -40,13 +38,6 @@ int main() { | |||
| Compatible &= Dev.is_gpu(); | |||
| Called = true; | |||
| } | |||
| if (sycl::is_compatible<KernelACC>(Dev)) { | |||
There was a problem hiding this comment.
Removing this since there is no chance now to launch this on fpga.
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@KseniyaTikhomirova take a look please |
|
|
||
| // RUN: %clangxx -fsycl -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx906 -fsycl-targets=amdgcn-amd-amdhsa %S/Inputs/is_compatible_with_env.cpp -o %t.out | ||
| // RUN: %clangxx -fsycl -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1030 %S/Inputs/is_compatible_with_env.cpp -o %t.out |
There was a problem hiding this comment.
is there a necessity to specify --offload-arch? it is absent for cuda, maybe can be skipped here either.
There was a problem hiding this comment.
I agree it may lead to a failure in the future if we change the hardware, but It looks like currently we don't specify the offload-arch automatically, need to extend the testing script. @intel/dpcpp-devops-reviewers am I missing something?
There was a problem hiding this comment.
Perhaps you could use %{hip_arch_opts}
see this bit,
Lines 239 to 246 in 0f42c75
Perhaps this could also be guarded by REQUIRES: any-target-is-amd instead of doing UNSUPPORTED: windows?
There was a problem hiding this comment.
Perhaps you could use %{hip_arch_opts}
As I understand hip_arch_opts works only with target-amd, so it won't be substituted otherwise.
this could also be guarded by REQUIRES: any-target-is-amd
the intention of this test is to be launched on other than amd platform to check if the is_compatible<kernel>(dev) call returns false if the kernel was built for another device.
|
@intel/llvm-gatekeepers could you please merge? |
updates UNSUPPORTED added in intel#17606
Due to incorrect REQUIRES these tests are never launched.