Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Consolidate platform and adapter backend enums into one. #17605

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Mar 24, 2025

second attempt to land #16173

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like a NFC to me, is that right?

@aarongreig
Copy link
Contributor Author

yeah I guess it kind of is, although as we've seen it does break other changes that use the affected enums

@aarongreig aarongreig requested review from a team as code owners April 4, 2025 13:11
@aarongreig
Copy link
Contributor Author

aarongreig commented Apr 4, 2025

ping @intel/dpcpp-nativecpu-reviewers note this is not a new patch, it's an attempt to re-land with a minor fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants