Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceSanitizers] Set names to nameless globals #17599

Merged

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Mar 24, 2025

DeviceSanitizer cannot handle nameless globals, but we cannot skip instrumenting them either. Therefore, we set names to nameless globals and process them like regular globals.

Also, this PR update two now deprecated API usage of getFirstNonPHI

@yingcong-wu yingcong-wu requested a review from a team as a code owner March 24, 2025 05:59
@yingcong-wu yingcong-wu changed the title save [DeviceSanitizers] Set names to nameless globals Mar 24, 2025
@yingcong-wu yingcong-wu changed the base branch from ci/update_gpu_driver-linux-igc-dev-e653864 to sycl March 24, 2025 06:00
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , please help merge this PR, thanks.

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , please help merge this PR. Thanks.

@aelovikov-intel aelovikov-intel merged commit 55416ca into intel:sycl Mar 26, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants