Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Uplift oclcpu from 2024.18.10.0.08 to 2025.19.3.0.17_230222 #17598

Merged
merged 3 commits into from
Apr 1, 2025
Merged

[CI] Uplift oclcpu from 2024.18.10.0.08 to 2025.19.3.0.17_230222 #17598

merged 3 commits into from
Apr 1, 2025
+12 −33

Conversation

yanfeng3721
Copy link
Contributor

No description provided.

@yanfeng3721 yanfeng3721 requested a review from a team as a code owner March 24, 2025 05:57
@yanfeng3721 yanfeng3721 marked this pull request as draft March 24, 2025 05:58
@yanfeng3721
Copy link
Contributor Author

hi @tfzhu , could you please prepare the following oclcpu links? Thanks.

  "github_tag": "2025-WW13",
  "version": "2025.19.3.0.17_230222",
  "url": "https://github.com/intel/llvm/releases/download/2025-WW13/oclcpuexp-2025.19.3.0.17_230222_rel.tar.gz",

  "github_tag": "2025-WW13",
  "version": "2025.19.3.0.17_230222",
  "url": "https://github.com/intel/llvm/releases/download/2025-WW13/win-oclcpuexp-2025.19.3.0.17_230222_rel.zip",

@yanfeng3721 yanfeng3721 requested review from tfzhu and dbriltz March 24, 2025 06:00
@yanfeng3721 yanfeng3721 changed the title [CI] Uplift oclcpu/oclfpgaemu from 2024.18.10.0.08 to 2025.19.3.0.17_230222 [CI] Uplift oclcpu from 2024.18.10.0.08 to 2025.19.3.0.17_230222 Mar 24, 2025
@tfzhu
Copy link
Contributor

tfzhu commented Mar 24, 2025

https://github.com/intel/llvm/releases/download/2025-WW13/win-oclcpuexp-2025.19.3.0.17_230222_rel.zip

Done

@yanfeng3721 yanfeng3721 requested a review from sarnex March 24, 2025 06:40
sarnex
sarnex reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanfeng3721 @tfzhu Some of the failures (not the dev igc ones) seem related, can you take a look? Thx

@yanfeng3721
Copy link
Contributor Author

Update TBB version to 2022.1.0

@sarnex
Copy link
Contributor

sarnex commented Mar 28, 2025 •
edited by yanfeng3721
Loading

Seeing an XPASS on BMG, can you fix it

XPASS: SYCL :: VirtualFunctions/misc/group-barrier.cpp (1286 of 2321)
******************** TEST 'SYCL :: VirtualFunctions/misc/group-barrier.cpp' FAILED ********************
Exit Code: 0

Command Output (stderr):
--
RUN: at line 19: env ONEAPI_DEVICE_SELECTOR=opencl:cpu  /__w/llvm/llvm/build-e2e/VirtualFunctions/misc/Output/group-barrier.cpp.tmp.out
+ env ONEAPI_DEVICE_SELECTOR=opencl:cpu /__w/llvm/llvm/build-e2e/VirtualFunctions/misc/Output/group-barrier.cpp.tmp.out

--

Sure, I will rerun the e2e tests first due to latest test result with updated TBB not finished successfully.

@yanfeng3721
[SYCL][E2E] Rmove XFAIL on CPU and Linux in VirtualFunctions/group-ba…
529201e 
…rrier test with uplifted oclcpu version 2025.19.3.0.17_230222
@yanfeng3721 yanfeng3721 marked this pull request as ready for review April 1, 2025 09:26
@yanfeng3721 yanfeng3721 requested a review from a team as a code owner April 1, 2025 09:26
@yanfeng3721 yanfeng3721 requested a review from slawekptak April 1, 2025 09:26
@yanfeng3721
Copy link
Contributor Author

Seeing an XPASS on BMG, can you fix it

XPASS: SYCL :: VirtualFunctions/misc/group-barrier.cpp (1286 of 2321)
******************** TEST 'SYCL :: VirtualFunctions/misc/group-barrier.cpp' FAILED ********************
Exit Code: 0

Command Output (stderr):
--
RUN: at line 19: env ONEAPI_DEVICE_SELECTOR=opencl:cpu  /__w/llvm/llvm/build-e2e/VirtualFunctions/misc/Output/group-barrier.cpp.tmp.out
+ env ONEAPI_DEVICE_SELECTOR=opencl:cpu /__w/llvm/llvm/build-e2e/VirtualFunctions/misc/Output/group-barrier.cpp.tmp.out

--

Sure, I will rerun the e2e tests first due to latest test result with updated TBB not finished successfully.

Fixed.

@sarnex
Copy link
Contributor

sarnex commented Apr 1, 2025

@aelovikov-intel @uditagarwal97 Can you guys review the test change here? Need to merge this (and then re-update all the Windows machines :( )

@sarnex sarnex requested a review from uditagarwal97 April 1, 2025 14:38
@sarnex sarnex requested a review from aelovikov-intel April 1, 2025 14:38
aelovikov-intel
aelovikov-intel approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever closed #15080 before this got merged made a mistake...

@sarnex sarnex merged commit e1befa7 into intel:sycl Apr 1, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@tfzhu tfzhu Awaiting requested review from tfzhu

@dbriltz dbriltz Awaiting requested review from dbriltz

@slawekptak slawekptak Awaiting requested review from slawekptak slawekptak is a code owner automatically assigned from intel/llvm-reviewers-runtime

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanfeng3721 @tfzhu @sarnex @aelovikov-intel