Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeviceSanitizer] Move isUnsupportedSPIRAccess to SPIRVSanitizerCommonUtils.cpp. #17597

Open
wants to merge 5 commits into
base: sycl
Choose a base branch
from
Open

[DeviceSanitizer] Move isUnsupportedSPIRAccess to SPIRVSanitizerCommonUtils.cpp. #17597

wants to merge 5 commits into from

Conversation

haonanya1
Copy link
Contributor

Both AddressSanitizer and MemorySanitizer ignore target extension type.

@haonanya1
[DeviceSanitizer] Move isUnsupportedSPIRAccess to SanitizerCommonUtil…
7aeb317 
…s namespace.

Both AddressSanitizer and MemorySanitizer ignore target extension type.
@haonanya1 haonanya1 requested review from a team as code owners March 24, 2025 05:34
yingcong-wu
yingcong-wu reviewed Mar 24, 2025
View reviewed changes
llvm/test/Instrumentation/MemorySanitizer/SPIRV/ignore_target_ext_type.ll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is sanitize_address and ; CHECK-NOT: call void @asan_load in this file. Is something wrong here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check lit, let me double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks.

@haonanya1 haonanya1 marked this pull request as draft March 24, 2025 05:45
@haonanya1 haonanya1 marked this pull request as ready for review March 24, 2025 06:45
@haonanya1 haonanya1 marked this pull request as draft March 24, 2025 06:46
@AllanZyne
Copy link
Contributor

AllanZyne commented Mar 25, 2025 •
edited
Loading

IMO, the file name "SanitizerCommonUtils" is too general, it doesn't look like a file specific to the device sanitizer.
Maybe, "SpirvSanitizerCommonUtils" is better.

@haonanya1
Copy link
Contributor Author

IMO, the file name "SanitizerCommonUtils" is too general, it doesn't look like a file specific to the device sanitizer. Maybe, "SpirvSanitizerCommonUtils" is better.

There is a file named SPIRITTAnnotations.h, What about SPIRVSanitizerCommonUtils?

@haonanya1 haonanya1 changed the title [DeviceSanitizer] Move isUnsupportedSPIRAccess to SanitizerCommonUtils namespace. [DeviceSanitizer] Move isUnsupportedSPIRAccess to SPIRVSanitizerCommonUtils namespace. Mar 25, 2025
@haonanya1 haonanya1 marked this pull request as ready for review March 25, 2025 05:53
@haonanya1 haonanya1 requested a review from yingcong-wu March 25, 2025 05:53
@haonanya1
Copy link
Contributor Author

@intel/dpcpp-tools-reviewers, could you please help me to trigger CI? Thanks.

@haonanya1 haonanya1 mentioned this pull request Mar 26, 2025
Open
@haonanya1 haonanya1 changed the title [DeviceSanitizer] Move isUnsupportedSPIRAccess to SPIRVSanitizerCommonUtils namespace. [DeviceSanitizer] Move isUnsupportedSPIRAccess to SPIRVSanitizerCommonUtils.cpp. Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingcong-wu yingcong-wu Awaiting requested review from yingcong-wu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haonanya1 @AllanZyne @yingcong-wu