Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland f9c8c01: [NVPTX] Aggressively try to replace image handles with references (#119730) #17592

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

Reland f9c8c01: [NVPTX] Aggressively try to replace image handles with references (#119730) #17592

wants to merge 2 commits into from

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Mar 22, 2025

  • [NVPTX] Aggressively try to replace image handles with references (#119730)
  • [NVPTX]: Fix NVPTXReplaceImageHandles after f9c8c01

AlexMaclean and others added 2 commits March 22, 2025 07:56
@AlexMaclean @jsji
[NVPTX] Aggressively try to replace image handles with references (#1…
01bbdd1 
…19730)

Even in cases where handles are supported, references are still
preferable for performance. This is because, a ref uses one
less register and can avoid the handle creating code associated with
taking the address of a tex/surf/sampler.
 Conflicts:
	llvm/test/CodeGen/NVPTX/surf-read-cuda.ll
	llvm/test/CodeGen/NVPTX/surf-tex.py
	llvm/test/CodeGen/NVPTX/surf-write-cuda.ll
	llvm/test/CodeGen/NVPTX/tex-read-cuda.ll
@jsji
[NVPTX]: Fix NVPTXReplaceImageHandles after f9c8c01
735b3b0
@jsji jsji requested a review from a team as a code owner March 22, 2025 15:00
@jsji jsji temporarily deployed to WindowsCILock March 22, 2025 15:00 — with GitHub Actions Inactive
@jsji jsji mentioned this pull request Mar 22, 2025
Open
@jsji jsji temporarily deployed to WindowsCILock March 22, 2025 16:18 — with GitHub Actions Inactive
@jsji jsji closed this Mar 28, 2025
@jsji jsji reopened this Mar 28, 2025
@jsji jsji temporarily deployed to WindowsCILock March 28, 2025 14:39 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 28, 2025 16:19 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 28, 2025 16:19 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsji @AlexMaclean