Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] Use size_t rather than unsigned long in WorkGroupScratchMemory tests #17100

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][E2E] Use size_t rather than unsigned long in WorkGroupScratchMemory tests #17100

wants to merge 1 commit into from
+2 −2

Conversation

RossBrunton
Copy link
Contributor

The max work group size is a size_t, rather than an unsigned long.
This trips up older versions of MSVC where size_t happens to be
unsigned long long.

@RossBrunton
[SYCL][E2E] Use size_t rather than unsigned long in WorkGroupScratchM…
391f5a4 
…emory tests

The max work group size is a `size_t`, rather than an `unsigned long`.
This trips up older versions of MSVC where `size_t` happens to be
`unsigned long long`.
@RossBrunton RossBrunton requested a review from a team as a code owner February 20, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RossBrunton @steffenlarsen