[UR] Logger callback function sink #17095
Open
+1,654
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/loggerCallbackSink
branch
from
d941614 to
a26217f
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Pre commit AMD job is failing with |
… callback function. Configurable through two new entry points with adapter implementations: urAdapterSetLoggerCallback() and urAdapterSetLoggerCallbackLevel(). Moved logger::level enum to the spec, named ur_logger_level_t. Added new unit test suite for these entry points. Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
martygrant
force-pushed
the
martin/loggerCallbackSink
branch
from
a26217f to
731f829
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
requested a deployment
to
WindowsCILock
GitHub Actions
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from oneapi-src/unified-runtime#1748
This PR implements oneapi-src/unified-runtime#1330 through a new logger sink: a user configurable callback. It introduces some spec additions:
typedef void (*ur_logger_output_callback_t)(ur_logger_level_t level, const char *pLoggerMsg, void *pUserData)urSetLoggerCallback(ur_adapter_handle_t hAdapter, ur_logger_output_callback_t pfnLoggerCallback, void *pUserData, ur_logger_level_t level)`
urSetLoggerCallbackLevel(ur_adapter_handle_t hAdapter, ur_logger_level_t level)typedef enum ur_logger_level_t(moved the logger::level enum into the spec)This new logger sink will only be constructed once a user makes a call to
urSetLoggerCallback, supplying their own callback function. They can set the minimum logging level throughurSetLoggerCallbackLevel. Any subsequent logging calls will additionally make a call to the supplied callback where the log level, message and user data will be sent.A new test suite
LoggerWithCallbackSinkhas been added to test this new functionality.