Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Improvements to align CTS and Spec for Program #17094

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

martygrant
Copy link
Contributor

Migrated from oneapi-src/unified-runtime#2697

  • All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added
  • Passing properties to urProgramCreateWithBinary
  • Added tests for passing options to urProgramCompile
    • Not passing any options to urProgramLink as there are no common platform independent options that I'm aware of
  • Added extra validation for urProgramRetain/Release
  • Added unowned native handle test for urProgramCreateWithNativeHandle

@martygrant
Copy link
Contributor Author

Pre commit AMD job is failing with Memory access fault by GPU node-1 (Agent handle: 0x10478090) on address 0x7b62a0014000. Reason: Page not present or supervisor privilege. this is being tracked here #10460

- All error returns for urProgramCreateWithIL are now covered, and a Success case with different properties has been added
- Passing properties to urProgramCreateWithBinary
- Added tests for passing options to urProgramCompile
- Added extra validation for urProgramRetain/Release
- Added unowned native handle test for urProgramCreateWithNativeHandle
@martygrant martygrant force-pushed the martin/program-cts-spec-gap branch from b99032d to 4b59eb0 Compare February 21, 2025 16:22
@martygrant martygrant deployed to WindowsCILock February 21, 2025 17:51 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant