Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Remove UNSUPPORTED from vector_with_virtual_mem.cpp #16969

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Feb 11, 2025

Remove UNSUPPORTED: linux && gpu-intel-dg2 from vector_with_virtual_mem.cpp as the test is passing consistently now.
Closes: #15812

@lbushi25 lbushi25 marked this pull request as ready for review February 12, 2025 14:56
@lbushi25 lbushi25 requested a review from a team as a code owner February 12, 2025 14:56
@aelovikov-intel
Copy link
Contributor

Remove UNSUPPORTED: linux && gpu-intel-dg2 from vector_with_virtual_mem.cpp as the test is passing consistently now.

Make sure to link GH issue so that it will be closed when this is merged (if appropriate).

@lbushi25
Copy link
Contributor Author

Remove UNSUPPORTED: linux && gpu-intel-dg2 from vector_with_virtual_mem.cpp as the test is passing consistently now.

Make sure to link GH issue so that it will be closed when this is merged (if appropriate).

Yes, there is a corresponding GH issue that should be closed. Added it to the description.

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers This should be good to merge. Failure is unrelated. This PR only touches one test but another one is failing.

@aelovikov-intel
Copy link
Contributor

@intel/llvm-gatekeepers This should be good to merge. Failure is unrelated. This PR only touches one test but another one is failing.

First, please list information about the failing test in your comment. Ideally, with a link to GH issue tracking it.

Second, your results on AMD HIP aren't ready yet.

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers This should be good to merge. Failure is unrelated. This PR only touches one test but another one is failing.

First, please list information about the failing test in your comment. Ideally, with a link to GH issue tracking it.

Second, your results on AMD HIP aren't ready yet.

For the first one, #16978 is the issue related to the fail

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers ping for merge. Test SYCL :: MemorySanitizer/check_device_global.cpp failing which is unrelated with corresponding ticket #16978

@aelovikov-intel aelovikov-intel merged commit 90fd252 into intel:sycl Feb 13, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SYCL :: VirtualMem/vector_with_virtual_mem.cpp failing on DG2 with driver 24.39.31294.12
2 participants