enable memory location query and set #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvrogozh
requested changes
Jun 1, 2022
va/va.h
Outdated
| * Image flags , app could retrieve surface informations by this flag after calling vaDeriveImage | ||
| * the flags could include the memory location/region etc. | ||
| * bit0 = 1: the flags is valid flags | ||
| * bit1-2: memory location: 0 system memeory, 1 local memory. |
There was a problem hiding this comment.
So, which bit is for system memory and which for local? did you intent to have bit1 only here?
There was a problem hiding this comment.
bit 1 -2 represent 2bit values, if bit0 is valid, then bit1 is 0 represent system memory, bit1 is 1 represent local memory, bit 2 is used for future, I will update it.
| * bit0 = 1: the flags is valid flags | ||
| * bit1-2: memory location: 0 system memeory, 1 local memory. | ||
| */ | ||
| uint32_t flags; |
There was a problem hiding this comment.
Can we introduce some bit masks to help users understand what's going on?
liangali
reviewed
Sep 15, 2022
| * bit0 = 1: the flags is valid flags | ||
| * bit1-2: memory location: 0 system memeory, 1 local memory. | ||
| */ | ||
| uint32_t flags; |
There was a problem hiding this comment.
Do we really need add this "flags" member in VAImage, since we can query memory region info through surfaceattributes (e.g., surface_attrib.value.value.i) ?
There was a problem hiding this comment.
the problem is we could not get surfaceattributes for one dedicate surface
XinfengZhang
force-pushed
the
location
branch
from
7488f49 to
d32f999
Compare
1. app could specify the memory location by vaCreateSurfaces 2. app could query the memory regions supported by backend driver 3. app could query the surface memory location by vaDeriveImage Signed-off-by: XinfengZhang <[email protected]>
XinfengZhang
force-pushed
the
location
branch
from
d32f999 to
10853eb
Compare
XinfengZhang
added a commit
to XinfengZhang/media-driver
that referenced
this pull request
Nov 25, 2022
1. it need definitions in intel/libva#601 2. default behavior is determined by driver (local memory prefered) 3. it will be impacted by platform WA such as WaForceAllocateLML3 Signed-off-by: Carl Zhang <[email protected]>
XinfengZhang
added a commit
to XinfengZhang/media-driver
that referenced
this pull request
Nov 25, 2022
it need definitions in intel/libva#601 Signed-off-by: Carl Zhang <[email protected]>
XinfengZhang
added a commit
to XinfengZhang/media-driver
that referenced
this pull request
Nov 25, 2022
1. it need definitions in intel/libva#601 2. default behavior is determined by driver (local memory prefered) 3. it will be impacted by platform WA such as WaForceAllocateLML3 Signed-off-by: Carl Zhang <[email protected]>
XinfengZhang
added a commit
to XinfengZhang/media-driver
that referenced
this pull request
Nov 25, 2022
it need definitions in intel/libva#601 Signed-off-by: Carl Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: XinfengZhang [email protected]