Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add output value interface for the values from driver #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XinfengZhang
Copy link
Contributor

sometimes , there are only one single value output
a new buffer type is complex than a api call

Signed-off-by: XinfengZhang [email protected]

@XinfengZhang XinfengZhang force-pushed the crc branch 2 times, most recently from 9f1a193 to b8415bc Compare June 15, 2018 07:52
sometimes , there are only one single value output
a new buffer type is complex than a new interface

Signed-off-by: XinfengZhang <[email protected]>
@fhvwy
Copy link
Contributor

fhvwy commented Jul 16, 2018

It might be sensible to have some sort of size information here. While the CRC hash in H.265 has a fixed size (number of planes * 16 bits, so usually 6 bytes), this API might be useful to use for something which doesn't.

That could either be passed in the function (e.g. an extra argument size_t *output_value_size set on input to the size of the buffer the user provides and on output to the actual amount written to output_value, with some error if it's not big enough), or there could be some separate query function to find out how big the output_value buffer needs to be.

VAStatus
(*vaQueryOutputValue)(
VADriverContextP ctx,
VAContextID context, /* in */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also add the surfaceID 'VASurfaceID render_target' in this interface? it maybe more flexiable for usage.

*/
VAStatus vaQueryOutputValue(
VADisplay dpy,
VAContextID context,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also add the surfaceID 'VASurfaceID render_target' in this interface? it maybe more flexiable for usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jexu, if add VASurfaceID render_target, it seems that it was changed to another function, calculate the input surface CRC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants