Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEXMANAGE-1265] Fix the permission issue during amt provisioning #633

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[NEXMANAGE-1265] Fix the permission issue during amt provisioning #633

wants to merge 4 commits into from

Conversation

yengliong93
Copy link
Contributor

@yengliong93 yengliong93 commented Feb 14, 2025 •
edited
Loading

PULL DESCRIPTION

Fix the permission issue during amt provisioning

Impact Analysis

Info Please fill out this column
Root Cause apparmor denied the access, rpc command asks for amt server password
Jira ticket NEXMANAGE-1265

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@yengliong93 yengliong93 marked this pull request as draft February 14, 2025 06:52
@yengliong93 yengliong93 marked this pull request as ready for review February 14, 2025 07:16
@yengliong93
[NEXMANAGE-1265] Fix AMT Provision Issue
8b67af3 
Fix the permission issue during amt provisioning.
- Update apparmor for the access
- Add password for AMT server

Signed-off-by: yengliong <[email protected]>
@yengliong93
Copy link
Contributor Author

Observed an error while sending the result in dispatcher.
image

@yengliong93
Copy link
Contributor Author

@gblewis1 @nmgaston @amarnath-ac please have a review, thanks.

@yengliong93 yengliong93 changed the title Fix the permission issue during amt provisioning [NEXMANAGE-1265] Fix the permission issue during amt provisioning Feb 14, 2025
@yengliong93
Copy link
Contributor Author

Observed an error while sending the result in dispatcher. image

Fixed.
image

gblewis1
gblewis1 requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@gblewis1 gblewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking merge until we have a new design for sending password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gblewis1 gblewis1 gblewis1 requested changes

@nmgaston nmgaston Awaiting requested review from nmgaston nmgaston is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yengliong93 @gblewis1