extractor.py #5003
Open
extractor.py #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Prioritize 7z for MSI extraction when both unzip and 7z are installed
This pull request addresses a bug in `cve-bin-tool` related to MSI file extraction.
* **Problem:** MSI extraction failed when both `unzip` and `7z` were installed.
* **Cause:** The tool's logic in `extractor.py` incorrectly prioritized `unzip` for MSI files, which `unzip` doesn't handle reliably.
* **Solution:** Modified the `extract_file_zip` function in `extractor.py`.
* Now, the tool checks for the `.msi` extension first.
* If the file is an MSI, it attempts extraction using `7z`.
* If `7z` fails or is not present, it falls back to `unzip` for other ZIP archives.
* **Benefit:** Ensures correct MSI extraction in environments with both `unzip` and `7z`.
* **Impact:** Improves the robustness of `cve-bin-tool` when analyzing Windows installer packages.
|
Hi maintainers 👋 This PR fixes an issue with MSI extraction by prioritizing 7z over unzip. Could someone please approve the workflows from the Actions tab so the CI checks can run? Thanks! |
|
Before approving this PR, can you first run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prioritize 7z for MSI extraction when both unzip and 7z are installed
This pull request addresses a bug in
cve-bin-toolrelated to MSI file extraction.unzipand7zwere installed.extractor.pyincorrectly prioritizedunzipfor MSI files, whichunzipdoesn't handle reliably.extract_file_zipfunction inextractor.py..msiextension first.7z.7zfails or is not present, it falls back tounzipfor other ZIP archives.unzipand7z.cve-bin-toolwhen analyzing Windows installer packages.