-
Notifications
You must be signed in to change notification settings - Fork 23
Camera trigger #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: iblrigv8dev
Are you sure you want to change the base?
Camera trigger #771
Conversation
Changes unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is pretty clean and the pesky conditional on the first trial is gone.
The concern here is mainly about the extraction, and how having the first camera pulses outside of the the behaviour state machine start may affect the researcher facing data.
So happy to merge, but to release we'll probably need a plan with @k1o0 if there are any ibllib changes necessary, or at the very least to try on a canary rig first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The camera trigger should be removed from the habituation choice world state machine also
Logic for triggering the camera and initial delay has been moved out of the state-machines for ChoiceWorldSession.