Skip to content

Camera trigger #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: iblrigv8dev
Choose a base branch
from
Open

Camera trigger #771

wants to merge 11 commits into from

Conversation

bimac
Copy link
Contributor

@bimac bimac commented Feb 20, 2025

Logic for triggering the camera and initial delay has been moved out of the state-machines for ChoiceWorldSession.

  • deprecation warning for custom tasks
  • unadapted tasks fall back to old behavior
  • documentation for adapting custom tasks
  • incremented version number

@coveralls
Copy link

coveralls commented Feb 20, 2025

Coverage Status

Changes unknown
when pulling a7fcb10 on camera_trigger
into ** on iblrigv8dev**.

@bimac bimac requested review from oliche and k1o0 February 20, 2025 18:11
@bimac bimac linked an issue Feb 20, 2025 that may be closed by this pull request
1 task
@bimac
Copy link
Contributor Author

bimac commented Feb 21, 2025

image

Copy link
Member

@oliche oliche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is pretty clean and the pesky conditional on the first trial is gone.

The concern here is mainly about the extraction, and how having the first camera pulses outside of the the behaviour state machine start may affect the researcher facing data.

So happy to merge, but to release we'll probably need a plan with @k1o0 if there are any ibllib changes necessary, or at the very least to try on a canary rig first.

Copy link
Contributor

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The camera trigger should be removed from the habituation choice world state machine also

@bimac bimac requested a review from k1o0 March 18, 2025 16:07
@bimac bimac mentioned this pull request Apr 1, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move check of camera TTL from state-machine to initialization
4 participants