Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Create status command #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Create status command #49

wants to merge 1 commit into from

Conversation

alias-mac
Copy link
Member

The status command should at least provide the following information for:

  • BOOT_INSULIN
    • PHP executable (works better on 5.4+)
    • PHP configuration used (path to the current php.ini file)
    • PHP OS information
    • Insulin version
  • BOOT_SUGAR_ROOT
    • Sugar version (like s:v command)
    • Sugar root (path)
  • BOOT_SUGAR_CONFIGURATION
    • DB information (driver, hostname, username, name)
    • Database password hidden by default
    • Cache directory path
    • Site URI
    • Upload directory path
    • Developer mode (active, inactive)
    • Logger level
    • Logger file
  • BOOT_SUGAR_DATABASE
    • Database connection status (connected, failure, etc)
  • BOOT_SUGAR_FULL
    • DB version (from config table)
    • License information
    • License download key hidden by default
  • BOOT_SUGAR_LOGIN
    • Sugar user (currently being used for the command)

Needs discussion

  • Proxy requirements code to call version safe code?
  • Ability to print information in JSON format?
  • Use keys instead and translate for table format? (format license.users, database.username, etc)
  • Sort data?

Known issues

  • Unit tests for code coverage
  • Provide safe configs (check isset or empty)
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #49

@alias-mac
Copy link
Member Author

We should also add the documentation for the command using the template (https://github.com/insulin/cli/wiki/Command-Specification-Template)

@ghost ghost assigned alias-mac and jcsmorais Dec 12, 2013
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.18%) when pulling 2fedee7 on alias-mac:ticket-49 into 5715b6c on insulin:master.


switch ($input->getOption('format')) {
case 'table':

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this extra line?

Adds ability to print in JSON format.

Hide passwords and download key by default. Passwords can be shown by passing
the `--show-passwords` option.
@@ -115,5 +115,20 @@ public function bootApplication();
* @throws \RuntimeException
* If login fails.
*/
public function localLogin();
public function localLogin($username);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this one should be in a separate PR since it was a typo currently on master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants