-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Create status command #49
base: master
Are you sure you want to change the base?
Conversation
We should also add the documentation for the command using the template (https://github.com/insulin/cli/wiki/Command-Specification-Template) |
|
||
switch ($input->getOption('format')) { | ||
case 'table': | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this extra line?
Adds ability to print in JSON format. Hide passwords and download key by default. Passwords can be shown by passing the `--show-passwords` option.
@@ -115,5 +115,20 @@ public function bootApplication(); | |||
* @throws \RuntimeException | |||
* If login fails. | |||
*/ | |||
public function localLogin(); | |||
public function localLogin($username); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this one should be in a separate PR since it was a typo currently on master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
The status command should at least provide the following information for:
Needs discussion
license.users
,database.username
, etc)Known issues
isset
orempty
)