docs: fix missing default component theme block in functional component doc pages #1920
Conversation
…nt doc pages INSTUI-4493
|
| @@ -33,6 +33,7 @@ import { SourceCodeEditor } from '@instructure/ui-source-code-editor' | |||
| import { withStyle, jsx } from '@instructure/emotion' | |||
|
|
|||
| import generateStyle from './styles' | |||
| import functionalComponentThemes from './functionalComponentThemes.ts' | |||
There was a problem hiding this comment.
I get a TS error in this line because the path has an extension
| avatar: async (theme) => | ||
| ( | ||
| await import('../../../../packages/ui-avatar/src/Avatar/theme.ts') | ||
| ).default(theme) |
There was a problem hiding this comment.
Could't we figure out the path from thge component ID? something like '../../../../packages/ui-${name}/src/${name.upper()}/theme.ts'.
I really don't like these 'enumerator' files, it's harder and harder to keep track on what is needed to have a working documentation. If its really needed could you put it into the root of the docs folder?
Also it would be great it we would see at least a console error if this thing is missing but should be there, but afaik this is not possible
There was a problem hiding this comment.
Unfortunately you can not use stuff that is not defined build time. aka: you can't use variables in these async imports because it will only know its value in runtime, which is too late already.
TEST_PLAN: Check Avatar (the only functional component at the moment) if it has the proper default themes block on it's docs page. Also check couple of others to check if they still have it
Closes: INSTUI-4493