test time select #1869
Open
test time select #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: When the test modifies the first time select, and it's onChange handler also modifies the second time select's value, next it can't clear the value of the second before typing in something new, so the two texts will be concatenated.
There is a modified example in ui-avatar.
Run the docs app and check out the avatar page to see the example
Run the avatar "new tests"
npm run test:vitest-watch packages/ui-avatarto see the test problems.Edit
packages/ui-avatar/src/Avatar/__new-tests__/Avatar.test.tsxto change tests