fix(ui-color-picker): add hex to aria-label #1857
Merged
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joyenjoyer
commented
Feb 7, 2025
| <Tooltip | ||
| renderTip={<div>{color}</div>} | ||
| elementRef={(element) => { | ||
| if ( |
There was a problem hiding this comment.
aria-describedby on the Tooltip's button has to be removed otherwise the Tooltip text is read aloud by screenreaders - we want to avoid this here because the aria-label has the same content in it already. I am using the Tooltip's elementRef property and the Element's API call to access the button.
joyenjoyer
commented
Feb 7, 2025
| {...(this.isSelectedColor(color) ? { 'aria-label': 'selected' } : {})} | ||
| {...{ | ||
| 'aria-label': `${color}${ | ||
| this.isSelectedColor(color) ? ' selected' : '' |
There was a problem hiding this comment.
If the color is selected, I append the 'selected' text to the hex code so the user gets information about that through the screenreader.
ToMESSKa
approved these changes
Feb 7, 2025
|
Don't forget to merge the commits into a single one. :) |
INSTUI-4273
joyenjoyer
force-pushed
the
INSTUI-4273-ensure-custom-controls-provide-proper-textual-name-role-and-state-information
branch
from
384f699 to
04eedba
Compare
joyenjoyer
deleted the
INSTUI-4273-ensure-custom-controls-provide-proper-textual-name-role-and-state-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4273
Test:
ColorPresetandColorContrastseparately, go to the docs page examples