test(ui-tray): migrate old Tray tests #1844
Conversation
|
|
|
||
| cy.get('[aria-label="Tray Example"]').as('tray') | ||
|
|
||
| cy.get('@tray').realPress('Escape') |
There was a problem hiding this comment.
The original test has a focus check on the tray before pressing the Esc key, which I don't see here.
There was a problem hiding this comment.
good catch but the Tray should close on escape whether it contains the focus or not so I think it's better to leave it out. maybe a separate test could be added to check with the shouldContainFocus prop set to true and some tabbing if it keeps the focus or not but that's out of scope for this PR
|
|
||
| cy.get('[aria-label="Tray Example"]').as('tray') | ||
|
|
||
| cy.get('@tray').realPress('Escape') |
There was a problem hiding this comment.
good catch but the Tray should close on escape whether it contains the focus or not so I think it's better to leave it out. maybe a separate test could be added to check with the shouldContainFocus prop set to true and some tabbing if it keeps the focus or not but that's out of scope for this PR
git-nandor
force-pushed
the
INSTUI-4424_convert_ui-tray_to_the_new_test_format
branch
from
ffd0bcb to
b6c6331
Compare
git-nandor
deleted the
INSTUI-4424_convert_ui-tray_to_the_new_test_format
branch
No description provided.