test(ui-selectable): migrate old Selectable tests #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ToMESSKa
requested changes
Jan 14, 2025
|
|
||
| expect(onClick).to.have.been.calledTwice() | ||
| expect(onRequestSelectOption).to.have.been.calledTwice() | ||
| await waitFor(() => { |
There was a problem hiding this comment.
here the expect for onClick being called twice is missing
There was a problem hiding this comment.
Expect for onClick has been added
balzss
approved these changes
Feb 3, 2025
|
|
||
| expect(onClick).to.have.been.calledTwice() | ||
| expect(onRequestSelectOption).to.have.been.calledTwice() | ||
| await waitFor(() => { |
git-nandor
force-pushed
the
INSTUI-4383_convert_ui-selectable_to_the_new_test_format
branch
4 times, most recently
from
73770d4 to
0877db4
Compare
git-nandor
force-pushed
the
INSTUI-4383_convert_ui-selectable_to_the_new_test_format
branch
from
0877db4 to
1d8f681
Compare
ToMESSKa
approved these changes
Feb 5, 2025
git-nandor
deleted the
INSTUI-4383_convert_ui-selectable_to_the_new_test_format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.