Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-calendar,ui-date-input): fix locale and timezone for simple api #1700

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Sep 27, 2024

Closes: INSTUI-4236

Locale and timezone was not passed down to the calendar in "minimal configuration" mode. Also fixes validation and formatting when locale has changed

TEST PLAN: pass locale to the <DateInput local="fr" and see if the weekdaylabels changed and different locale dates are validated correctly

Copy link

Preview URL: https://1700--preview-instui.netlify.app

@HerrTopi HerrTopi requested review from balzss and removed request for joyenjoyer October 2, 2024 15:14
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@HerrTopi HerrTopi merged commit 67e6d1f into v8_maintenance Oct 2, 2024
3 checks passed
@HerrTopi HerrTopi deleted the fixlocale branch October 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants