feat(ui-top-nav-bar): add workaround hack for new topnav design with the old api #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1571--preview-instui.netlify.app |
balzss
changed the title
balzss
force-pushed
the
feat/navbar-small-viewport-brand-hack
branch
from
9e9ca6e to
c1578ff
Compare
balzss
changed the title
matyasf
approved these changes
Jul 10, 2024
Comment on lines
117
to
119
| /** | ||
| * Stay away... | ||
| */ |
There was a problem hiding this comment.
Please add a proper description. We should also mention that this is a deprecated prop that people should not use
joyenjoyer
reviewed
Jul 15, 2024
| /** | ||
| * Stay away... | ||
| */ | ||
| renderNavbarStartDangerousHack?: React.ReactNode |
There was a problem hiding this comment.
Maybe expand the type with HTMLElement if someone wants to add a simple html tag, otherwise nice job.
There was a problem hiding this comment.
regular html tags should be compatible with ReactNode, at least in my testings it didn't throw any error for them
joyenjoyer
requested changes
Jul 15, 2024
balzss
force-pushed
the
feat/navbar-small-viewport-brand-hack
branch
from
c1578ff to
ad3f613
Compare
balzss
force-pushed
the
feat/navbar-small-viewport-brand-hack
branch
from
ad3f613 to
ba3161d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4121
test plan:
renderNavbarStartDangerousHackprop to thesmallViewportConfig