Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui-pill): migrate old Pill tests #1565

Merged
merged 1 commit into from
Jul 16, 2024
Merged

test(ui-pill): migrate old Pill tests #1565

merged 1 commit into from
Jul 16, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Jul 2, 2024

Closes: INSTUI-4112

@ToMESSKa ToMESSKa self-assigned this Jul 2, 2024
@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Preview URL: https://1565--preview-instui.netlify.app

@ToMESSKa ToMESSKa marked this pull request as ready for review July 3, 2024 14:18
@ToMESSKa ToMESSKa force-pushed the INSTUI-4112_convert_ui-pill_to_the_new_test_format branch from ad1add8 to 98e98cf Compare July 3, 2024 14:21
joyenjoyer
joyenjoyer requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented line.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4112_convert_ui-pill_to_the_new_test_format branch 2 times, most recently from 0b4cb40 to 51a9faa Compare July 9, 2024 09:18
@ToMESSKa ToMESSKa requested a review from joyenjoyer July 10, 2024 09:08
@ToMESSKa ToMESSKa force-pushed the INSTUI-4112_convert_ui-pill_to_the_new_test_format branch from 51a9faa to f70a78d Compare July 10, 2024 09:08
@ToMESSKa ToMESSKa force-pushed the INSTUI-4112_convert_ui-pill_to_the_new_test_format branch 4 times, most recently from cfcb35e to 740700f Compare July 16, 2024 07:06
@ToMESSKa ToMESSKa force-pushed the INSTUI-4112_convert_ui-pill_to_the_new_test_format branch from 740700f to c652011 Compare July 16, 2024 09:05
@ToMESSKa ToMESSKa merged commit 143136a into master Jul 16, 2024
8 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4112_convert_ui-pill_to_the_new_test_format branch July 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@balzss balzss balzss approved these changes

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@git-nandor git-nandor Awaiting requested review from git-nandor

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ToMESSKa @CLAassistant @matyasf @balzss @joyenjoyer