refactor(many): remove TransformImports just form theme packages

instructure · Oct 21, 2024 · e4167a8 · e4167a8
1 parent 9208396
commit e4167a8
Show file tree

Hide file tree

Showing 6 changed files with 38 additions and 4 deletions.
diff --git a/packages/canvas-high-contrast-theme/babel.config.js b/packages/canvas-high-contrast-theme/babel.config.js
@@ -30,7 +30,7 @@ module.exports = {
         coverage: Boolean(process.env.COVERAGE),
         esModules: Boolean(process.env.ES_MODULES),
         removeConsole: process.env.NODE_ENV === 'production',
-        transformImports: Boolean(process.env.TRANSFORM_IMPORTS)
+        transformImports: false
       }
     ]
   ]

diff --git a/packages/canvas-theme/babel.config.js b/packages/canvas-theme/babel.config.js
@@ -30,7 +30,7 @@ module.exports = {
         coverage: Boolean(process.env.COVERAGE),
         esModules: Boolean(process.env.ES_MODULES),
         removeConsole: process.env.NODE_ENV === 'production',
-        transformImports: Boolean(process.env.TRANSFORM_IMPORTS)
+        transformImports: false
       }
     ]
   ]

diff --git a/packages/ui-babel-preset/lib/index.js b/packages/ui-babel-preset/lib/index.js
@@ -42,6 +42,35 @@ module.exports = function (
   ]
 
   let plugins = []
+  if (opts.transformImports) {
+    plugins.push([
+      require('@instructure/babel-plugin-transform-imports'),
+      {
+        '(@instructure/ui-[^(/|\\s)]+)$': {
+          // eslint-disable-line no-useless-escape
+          transform: (importName, matches) => {
+            const ignore = [
+              '@instructure/ui-test-queries',
+              '@instructure/ui-test-sandbox',
+              '@instructure/ui-test-utils'
+            ]
+
+            if (!matches || !matches[1] || ignore.includes(matches[1])) return
+            return `${matches[1]}/lib/${importName}`
+          }
+        },
+        // Convert any es imports to lib imports
+        '(@instructure/ui-[^(/|\\s)]+/es/[^\\s]+)$': {
+          // eslint-disable-line no-useless-escape
+          transform: (importName, matches) => {
+            if (!matches || !matches[1]) return
+            return matches[1].replace(new RegExp('/es/'), '/lib/')
+          }
+        },
+        ...(opts.importTransforms || {})
+      }
+    ])
+  }
   // Work around https://github.com/babel/babel/issues/10261, which causes
   // Babel to not use the runtime helpers for things like _objectSpread.
   // Remove this once that babel issue is fixed

diff --git a/packages/ui-babel-preset/package.json b/packages/ui-babel-preset/package.json
@@ -31,6 +31,7 @@
     "@babel/preset-react": "^7.22.15",
     "@babel/preset-typescript": "^7.23.2",
     "@babel/runtime": "^7.23.2",
+    "@instructure/babel-plugin-transform-imports": "8.56.4",
     "@instructure/browserslist-config-instui": "8.56.4",
     "babel-loader": "^9.1.3",
     "babel-plugin-dynamic-import-node": "^2.3.3",

diff --git a/packages/ui-babel-preset/tsconfig.build.json b/packages/ui-babel-preset/tsconfig.build.json
@@ -7,5 +7,9 @@
     "outDir": "./types"
   },
   "include": ["lib"],
-  "references": []
+  "references": [
+    {
+      "path": "../babel-plugin-transform-imports/tsconfig.build.json"
+    }
+  ]
 }
diff --git a/packages/ui-themes/babel.config.js b/packages/ui-themes/babel.config.js
@@ -30,7 +30,7 @@ module.exports = {
         coverage: Boolean(process.env.COVERAGE),
         esModules: Boolean(process.env.ES_MODULES),
         removeConsole: process.env.NODE_ENV === 'production',
-        transformImports: Boolean(process.env.TRANSFORM_IMPORTS)
+        transformImports: false
       }
     ]
   ]