Skip to content

Commit

Permalink
fix(ui-menu): make Menu.Item apply target prop
Browse files Browse the repository at this point in the history
  • Loading branch information
ToMESSKa committed Jan 17, 2025
1 parent 43fde61 commit 6c85b31
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/ui-menu/src/Menu/MenuItem/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ class MenuItem extends Component<MenuItemProps, MenuItemState> {
}

render() {
const { disabled, controls, onKeyDown, onKeyUp, type, href } = this.props
const { disabled, controls, onKeyDown, onKeyUp, type, href, target } =
this.props

const props = omitProps(this.props, MenuItem.allowedProps)
const ElementType = this.elementType
Expand All @@ -247,6 +248,7 @@ class MenuItem extends Component<MenuItemProps, MenuItemState> {
tabIndex={-1} // note: tabIndex can be overridden by Menu or MenuItemGroup components
{...props}
href={href}
target={target}
role={this.role}
aria-labelledby={this.labelId}
aria-disabled={disabled ? 'true' : undefined}
Expand Down

0 comments on commit 6c85b31

Please sign in to comment.