refactor(ui-pagination): fix failing tests

instructure · Feb 3, 2025 · 55b1e3d · 55b1e3d
1 parent 1dbe539
commit 55b1e3d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/packages/ui-pagination/src/Pagination/__new-tests__/Pagination.test.tsx b/packages/ui-pagination/src/Pagination/__new-tests__/Pagination.test.tsx
@@ -123,20 +123,17 @@ describe('<Pagination />', () => {
     it('by default', async () => {
       const { container } = render(
         <Pagination variant="compact" labelNext="Next" labelPrev="Prev">
-          <ul>
-            {buildPages(5)}
-          </ul>
+          {buildPages(5)}
         </Pagination>
       )
-
       const axeCheck = await runAxeCheck(container)
       expect(axeCheck).toBe(true)
     })
 
     it('by default with more pages', async () => {
       const { container } = render(
         <Pagination variant="compact" labelNext="Next" labelPrev="Prev">
-          <ul>{buildPages(8)}</ul>
+          {buildPages(8)}
         </Pagination>
       )
       const axeCheck = await runAxeCheck(container)
@@ -153,7 +150,7 @@ describe('<Pagination />', () => {
           labelLast="Last"
           withFirstAndLastButton
         >
-          <ul>{buildPages(8)}</ul>
+          {buildPages(8)}
         </Pagination>
       )
       const axeCheck = await runAxeCheck(container)
@@ -171,7 +168,7 @@ describe('<Pagination />', () => {
           withFirstAndLastButton
           showDisabledButtons
         >
-          <ul>{buildPages(8)}</ul>
+          {buildPages(8)}
         </Pagination>
       )
       const axeCheck = await runAxeCheck(container)
@@ -966,7 +963,7 @@ describe('<Pagination />', () => {
           totalPageNumber={9}
         />
       )
-      expect(container.firstChild).toHaveTextContent('12...9Next Page')
+      expect(container.firstChild).toHaveTextContent('12…9Next Page')
     })
     it('should render the correct pages - 2', () => {
       const { container } = render(
@@ -979,7 +976,7 @@ describe('<Pagination />', () => {
         />
       )
       expect(container.firstChild).toHaveTextContent(
-        'Previous Page1...456...9Next Page'
+        'Previous Page1…456…9Next Page'
       )
     })
     it('should render the correct pages - 3', () => {
@@ -1011,7 +1008,7 @@ describe('<Pagination />', () => {
         />
       )
       expect(container.firstChild).toHaveTextContent(
-        'Previous Page12...456...89Next Page'
+        'Previous Page12…456…89Next Page'
       )
     })
     it('should render the correct pages - 5', () => {
@@ -1056,7 +1053,7 @@ describe('<Pagination />', () => {
           siblingCount={1}
         />
       )
-      expect(container.firstChild).toHaveTextContent('123...789Next Page')
+      expect(container.firstChild).toHaveTextContent('123…789Next Page')
     })
     it('should render the correct ellipsis', () => {
       const { container } = render(
@@ -1098,7 +1095,7 @@ describe('<Pagination />', () => {
         />
       )
       expect(container.firstChild).toHaveTextContent(
-        'Previous Page1...567756785679...1000000000000000Next Page'
+        'Previous Page1…567756785679…1000000000000000Next Page'
       )
     })
     it('should render first and last buttons', () => {
@@ -1115,7 +1112,7 @@ describe('<Pagination />', () => {
         />
       )
       expect(container.firstChild).toHaveTextContent(
-        'First PagePrevious Page1...456...100Next PageLast Page'
+        'First PagePrevious Page1…456…100Next PageLast Page'
       )
     })
     it('should render every page if boundary and sibling counts are big enough', () => {

diff --git a/packages/ui-pagination/src/Pagination/index.tsx b/packages/ui-pagination/src/Pagination/index.tsx
@@ -104,7 +104,7 @@ class Pagination extends Component<PaginationProps> {
     currentPage: 1,
     siblingCount: 1,
     boundaryCount: 1,
-    ellipsis: '...',
+    ellipsis: '…',
     renderPageIndicator: (page: number) => page
   }