Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getting window handle in W3C mode #136

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Allow getting window handle in W3C mode #136

merged 1 commit into from
Mar 27, 2025

Conversation

aik099
Copy link
Contributor

@aik099 aik099 commented Mar 19, 2024 •
edited
Loading

The $session->window()->handle(); code had several issues:

  1. the URL queried for the window handle was /session/{session id}/windowsession/{session id}/window
  2. there was a PHP Notice, where a returned window handle (for me it was always a string) was treated as an array

Both issues are addressed in this PR.

@aik099
Copy link
Contributor Author

aik099 commented May 12, 2024

@robocoder , pleas review.

@aik099
Copy link
Contributor Author

aik099 commented Jul 18, 2024

@robocoder , please review.

1 similar comment
@aik099
Copy link
Contributor Author

aik099 commented Oct 31, 2024

@robocoder , please review.

@robocoder robocoder merged commit 06c9b52 into instaclick:master Mar 27, 2025
0 of 6 checks passed
@aik099
Copy link
Contributor Author

aik099 commented Mar 28, 2025

Thank you.

@aik099 aik099 deleted the window-handle-retrieval-fix branch March 28, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aik099 @robocoder