Increase resolution of log timestamps #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'c' format does not include milliseconds. This causes logs sent within the same second to sometimes appear out of order. Change to use the `\DateTimeInterface::RFC3339_EXTENDED` constant which includes milliseconds. After testing, I found that Logz.io truncates timestamps containing microseconds. There is no need to be that fine-grained.
Chrico
reviewed
May 3, 2022
There was a problem hiding this comment.
Good morning ☕ and sorry for the late response. This kind of got lost in my inbox 🤔
It looks like that the format of RFC3339_EXTENDED is different to c (ISO 8601). So i'm wondering if this will not cause any errors. By looking into other implementation like logzio-nodejs i can see they are also using the ISO format: https://github.com/logzio/logzio-nodejs/blob/master/lib/logzio-nodejs.js#L184
Can you provide any more context (maybe from official documentation) if RFC3339 format is accepted? Couldn't find any information in their docs about that 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'c' format does not include milliseconds. This causes logs sent within the same second to sometimes appear out of order.
Change to use the
\DateTimeInterface::RFC3339_EXTENDEDconstant which includes milliseconds.After testing, I found that Logz.io truncates timestamps containing microseconds. There is no need to be that fine-grained.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds milliseconds to the
@timestampfield sent to Logz.io.What is the current behavior? (You can also link to an open issue here)
The
@timestampfield only goes down to the seconds resolution.What is the new behavior (if this is a feature change)?
Logs sent to Logz.io now have milliseconds, making them higher resolution and less likely to be out of order.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking change. This only works on PHP 7.2.0+, but that is already embedded in the
composer.json.Other information: