-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate crates #832
Conversation
@rex4539 What is the goal of these changes? There is zero information in the commit message or pull request description, and I can't tell from these changes if there's an actual benefit to them. |
When you have multiple packages in a Cargo workspace, you often end up depending on the same packages in multiple Cargo.toml files. This duplication can become an issue: This process it's error-prone and tedious. If you mess it up, you end up with different versions of the same dependency within your workspace. This can lead to hard-to-debug compilation errors or bloat your artifacts with unnecessary copies of the same package. |
@rex4539 While there are some overlapping packages in between the crates, most of them have unique dependencies, so moving them to the workspace level won't help much. As far as duplicate crates go, this isn't much of an issue either per
Maintenance wise I actually prefer to keep dependencies isolated to their crates, as the workspace approach actually seems to introduce duplicate work: you have to specify a dependency entry at the crate level and the workspace level, instead of only at the crate level. Based on this, we won't adopt this workspace dependency approach. For future contributions, please create an issue first and discuss the proposal there (see also our contributing guidelines). This way you can avoid spending time on work that will be rejected anyway. |
No description provided.