fix sumcheck transcript-config copy rather than move #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanfr-ingo
approved these changes
Mar 6, 2025
yshekel
force-pushed
the
yshekel/fix_sumcheck_transcript_bug
branch
from
4dba784 to
5077034
Compare
mickeyasa
approved these changes
Mar 6, 2025
| @@ -82,7 +82,7 @@ namespace icicle { | |||
|
|
|||
| // Move Constructor | |||
| SumcheckTranscriptConfig(SumcheckTranscriptConfig&& other) noexcept | |||
| : m_hasher(other.m_hasher), m_domain_separator_label(std::move(other.m_domain_separator_label)), | |||
| : m_hasher(std::move(other.m_hasher)), m_domain_separator_label(std::move(other.m_domain_separator_label)), | |||
There was a problem hiding this comment.
do we have move for hasher?
There was a problem hiding this comment.
I think it's more correct for a move constructor. In this case copy is cheap but still.
| const bool m_little_endian = true; ///< Encoding endianness (default: little-endian). | ||
| F m_seed_rng; ///< Seed for initializing the RNG. | ||
| Hash m_hasher; ///< Hash function used for randomness generation. | ||
| std::vector<std::byte> m_domain_separator_label; ///< Label for the domain separator in the transcript. |
There was a problem hiding this comment.
why not const?
doesn't it work with the move?
There was a problem hiding this comment.
Yes it makes the move copy instead. Now I test it in one test. I tried different things to make it const but failed
yshekel
force-pushed
the
yshekel/fix_sumcheck_transcript_bug
branch
from
5077034 to
45cafa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical issue in the SumcheckTranscript API where move semantics are improperly implemented due to the use of const rvalue references. This misuse leads to unintended copying of objects instead of moving them, which contradicts the original design intentions and can lead to performance degradation, especially since some of the data structures involved (like labels and public data) are potentially large.
Issues Addressed:
const SumcheckTranscriptConfig<S>&&). This approach mistakenly assumes that objects can be moved efficiently, but due to their constness, they are actually copied. This undermines the efficiency of move semantics.cuda-backend-branch: yshekel/fix_sumcheck_transcript