Custom combine functions for sumcheck (ReturningValueProgram) in rust #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with custom combine function Signed-off-by: Koren-Brand <[email protected]>
mickeyasa
requested changes
Mar 5, 2025
|
|
||
| // Friend function for C-api to have access to update the poly degree after generation | ||
| template <typename T> | ||
| friend void set_poly_degree(ReturningValueProgram<T>* program, int poly_degree); |
There was a problem hiding this comment.
move this function into generate_program.
implement new generate_program function at ReturningValueProgram that calls Program::generate_program and run the set poly degree code
icicle/src/program/program_c_api.cpp
Outdated
| (*program)->generate_program(parameters_vec); | ||
| set_poly_degree(*program, parameters_ptr[nof_parameters - 1]->m_operation->m_poly_degree); | ||
|
|
||
| ReleasePool<Symbol<scalar_t>>& pool = ReleasePool<Symbol<scalar_t>>::instance(); |
There was a problem hiding this comment.
you can use ReleasePool<Symbol<scalar_t>>::instance().clear()
icicle/src/program/program_c_api.cpp
Outdated
| ProgramHandle program = *returning_program; | ||
| return CONCAT_EXPAND(FIELD, generate_program)(parameters_ptr, nof_parameters, &program); | ||
| *program = create_empty_returning_value_program<scalar_t>(); | ||
| std::vector<Symbol<scalar_t>> parameters_vec; |
There was a problem hiding this comment.
all this code is replicated - use function
…api, inserting poly_degree change into returning program's generate function Signed-off-by: Koren-Brand <[email protected]>
yshekel
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed ReturningValueProgram creation in the rust wrapper
Added test checking Sumchek with a custom combine function