Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRI Implementation: frontend + CPU Backend + GPU Backend #795
base: main
Are you sure you want to change the base?
FRI Implementation: frontend + CPU Backend + GPU Backend #795
Changes from 106 commits
b848b0e
92f3579
d6a9c59
e6672ff
bb3b1d5
46b4d72
563694d
ee5b5de
aa68bb5
ffae6b4
f3331cc
6cdcee8
9e9ca5a
766dbe9
588a84c
1a83ec2
e7ed244
7248477
4a22355
a9b6256
b989711
6a71b95
44663c1
85de44d
01b7137
d61ca9e
d8abe7a
6550860
30fc2bb
1628b52
3b1165e
698fb7e
b2b5ff1
3928fd9
8cc6078
a00a1d1
17fb2d1
d7673f6
3cb70fa
07c1e85
9e60bb9
53dd569
b7d5ddc
d94ebec
7b06f73
2840f91
c22d38e
48f30df
81d870f
5baee05
ae57939
7956576
51d6e8d
5bd4e56
6d20856
9ea4eea
a9da45d
17a659e
12469fb
bc5e639
8447e1a
db78555
28cab47
31dbb47
64767a6
be8cd4c
7f98ad6
8a02604
752dc93
87677d0
31a5efb
430afc1
b478aa6
9ee1b8d
7e3dbd5
c35f823
a334b0e
1b1fc4e
c4122f1
c06a038
c2953a1
2efd9ae
40392af
1048dfb
d11f03a
e503dd8
b4b2d1d
59b0e72
dc3f2bf
0b4dafe
cdbe020
0e8670a
13ef0f0
00a5ef3
518318d
a9bce88
77f2646
907abbf
627947b
42fa634
1569b2a
02a39f5
7205dbe
f5cefa1
755b0f5
9b2a900
366f1b8
f092a76
881f0cb
20585e6
48da21b
9ab1880
f4fc903
4cefe5d
bd238aa
6319dee
01893ed
5f49f36
14db388
2f16963
2d792dc
fafb40d
c1eb318
0746e1b
6f6435b
19abf19
c205291
39ab65f
d69b33e
4da615c
56ed067
d80d180
414b7dc
d3789cb
58a8cc7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is probably better to get the size of input_data here as another parameter. You assume it is valid but maybe it's not. If not, you need to identify and log an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new API its not relevant right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should accept the size and not assume it it valid when you take a pointer like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new API its not relevant right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a bad idea to store a reference to another object like that since you don't control its lifetime and it may be released too soon (before the FriRounds object). In such cases you need to either pass by value, move or use a smart pointer. Even if this is not exposed to users, it still creates coupling and assumptions for code using this class and changes in other places may break this code.