Implement Integer Rings in RNS Representation #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
changed the title
yshekel
requested review from
HadarIngonyama,
ChickenLover,
jeremyfelder,
emirsoyturk,
mickeyasa and
LeonHibnik
mickeyasa
reviewed
Feb 24, 2025
yshekel
force-pushed
the
yshekel/ring_rns
branch
from
4187f2d to
583c14d
Compare
yshekel
force-pushed
the
yshekel/ring_rns
branch
from
547c8b8 to
c3e66ee
Compare
Co-authored-by: Leon Hibnik <[email protected]>
fix: allow sumcheck tests to run without cuda backend
Running over the MLE polynomials in a serial order. Parallelizing the sum of the MLE polynomials over multiple threads.
Co-authored-by: Leon Hibnik <[email protected]>
yshekel
force-pushed
the
yshekel/ring_rns
branch
from
c309b1e to
cb20581
Compare
mickeyasa
reviewed
Mar 3, 2025
mickeyasa
reviewed
Mar 3, 2025
emirsoyturk
approved these changes
Mar 3, 2025
| } | ||
|
|
||
| // Arithmetic Operators | ||
| friend HOST_DEVICE_INLINE IntegerRingRns operator+(const IntegerRingRns& a, const IntegerRingRns& b) |
There was a problem hiding this comment.
a general comment: do we need to add compound assignments. we also don't have it for Fields
There was a problem hiding this comment.
We could, I am not sure it's more efficient but we could when we need it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a template class for integer rings in the Residue Number System (RNS) representation. Instead of storing an integer modulo a composite modulus q = p1 * p2 * ... * pn, this implementation represents the integer as a tuple (x mod p1, x mod p2, ..., x mod pn), where each component resides in a different field.
Future PRs:
cuda-backend-branch: yshekel/ring_rns