-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reqwest Client (Tokio 1.0 support) #92
Conversation
@Empty2k12 As I mentioned before, these I've asked you before if you want me to do a separate PR to fix those warnings, and suggested to just remove the offensive function, as it just calls another public function and nothing else. Your only reply was Gute Frage. |
If this is the only thing keeping this from being merged I think it might make sense to just add it to the PR. I think tokio 1.x support is essential. |
If @Empty2k12 could decide if he wants the API to promote |
Fixes #82
Fixes #90
Description
Using reqwest over surf has a few advantages:
However, I've kept the existing surf-based feature flags for those that really need async-std compatibily.
Some notes:
socket2
dependency compiles#[cfg]
statements more complex. Also, there are other error messages than my custom ones, which could be suppressed but would add more complexity.Checklist
cargo fmt --all
cargo clippy --all-targets --all-features -- -D warnings
- I didn't introduce those warningscargo readme -r influxdb -t ../README.tpl > README.md