-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json to support @typescript-eslint version 6 #64
Conversation
@matzehecht Thank you for the contribution! Could you please have a look into failed tasks? 🙏 |
@infctr I am trying to figure out, why this happens. I am currently clueless. So help would be appreciated 😅 |
I tried again today. The issue can only be resolved by updating typescript to a version higher than 4.7. But this leads to errors in other dependencies (e.g. @typescript-eslint/experimental-utils which is deprecated a long time and eslint-plugin-import). Updating those lead to some other breaking changes in the code itself (e.g. the "recommended" config of the rules or similar) and to issues with other dependencies as there are at least 22 dependencies outdated (and some of them are outdated a long time). |
Is there a smaller change that could be made to unblock users of this library so they can upgrade to typescript-eslint v6 without breaking the tests? For example, would changing this in package.json: "@typescript-eslint/parser": "^1 || ^2 || ^3 || ^4 || ^5", to this: "@typescript-eslint/parser": "^1 || ^2 || ^3 || ^4 || ^5 || ^6", work? Then the TypeScript issues could be resolved at a later time in a separate PR. |
What is the status of this? Can we get that change to add ^6? |
Fixed in #67 |
Bump peerDependency @typescript-eslint/parser to support version 6.0.0.
Bump devDependency @typescript-eslint/parser and @typescript-eslint/eslint-plugin to 6.0.0
Pay attention, the minimum required node.js version is now set to 16, since @typescript-eslint itself only supports 16 and up (See v6.0.0 Release Notes).