Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set Inertia SSR URL via the ENV variable #172

Conversation

brodienguyen
Copy link
Contributor

This PR introduces the ability to set ssr_url dynamically using an ENV variable (INERTIA_SSR_URL) with a fallback value. This change is based on recent discussions about improving flexibility in configuring the Inertia SSR URL at:

Copy link
Collaborator

@BrandonShar BrandonShar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! The only mild pushback I'd have is that couldn't we already do this with an initializer? The convenience here is nice though.

@brodienguyen
Copy link
Contributor Author

Closing in the favor of:

@brodienguyen brodienguyen deleted the allow-to-set-Inertia-SSR-URL-from-the-env-variable branch February 19, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants