This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Remove uses of Guava methods removed in Guava 21.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, it looks like there's a test failing non-deterministically w/the CI build, unrelated to this PR. |
|
Thanks, Shawn. My unmerged branch for #18 was conflating Guava 21 compatibility with "built with Guava 21 and Java 8". We'll get this merged and published. |
|
Did this change cause problems? Looks above like it was merged, but release 1.1.37 (made this morning) doesn't have it and I don't see it in the commit history for |
|
@shawnsmith I apologize, we have an issue with our syncing from private to public repo. Do you still have your branch around? If not, I can re-create your change from memory. |
|
Yep, I have it. Just used it to create another PR #21. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Objects.firstNonNullmethod was deprecated in Guava 18.0 and removed in Guava 21.0.As far as I can tell, this change makes Proctor compatible with projects that use Guava 21.0.
This addresses the same problem as #18 but in a minimal way that should make it easier to merge.