[TASK] Improve cache handling #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, in2publish only clears the cache of all published changes.
This is not the same behaviour as used in the core. This can cause the
following problem:
1. Create a page with a menu_menu_subpages element.
2. Publish that page.
3. View that page on the foreign system.
4. Create a child page on local.
5. Observe the menu_menu_subpages listing the child page on local.
6. Publish the child page.
7. Observe the menu_menu_subpages not listing the child page on
foreign.
To view the page in the menu_menu_subpages, you need to clear frontend
caches on foreign.
This patch changes the behaviour of in2publish to mirror that of the
backend. In order to do that, internal functionality is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, in2publish only clears the cache of all published changes. This is not the same behaviour as used in the core. This can cause the following problem:
To view the page in the menu_menu_subpages, you need to clear frontend caches on foreign.
This patch changes the behaviour of in2publish to mirror that of the backend. In order to do that, internal functionality is used.