Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Return 404 for campaign pages when disabled on the campaign #7716

Merged

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Feb 7, 2025

Resolves GIVE-2144

Description

This PR hooks into the page load to return a 404 for a Campaign Page when the campaign page feature is disabled on the campaign.

Testing Instructions

Create a Campaign and edit the Campaign Page. Then disable the campaign page feature and try to load the Campaign Page as a site visitor.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson changed the base branch from develop to epic/campaigns February 7, 2025 18:03
@kjohnson kjohnson marked this pull request as ready for review February 7, 2025 18:04
@kjohnson
Copy link
Contributor Author

@jonwaldstein I've committed your suggestions and re-tested locally. Ready for re-review.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjohnson great job man!

@kjohnson
Copy link
Contributor Author

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@kjohnson kjohnson merged commit 71e0a06 into epic/campaigns Feb 21, 2025
8 of 20 checks passed
@kjohnson kjohnson deleted the fix/campaign-page-redirect-disabled-GIVE-2144 branch February 21, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants