-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Return 404 for campaign pages when disabled on the campaign #7716
Fix: Return 404 for campaign pages when disabled on the campaign #7716
Conversation
Co-authored-by: Jon Waldstein <[email protected]>
Co-authored-by: Jon Waldstein <[email protected]>
@jonwaldstein I've committed your suggestions and re-tested locally. Ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjohnson great job man!
Build for QA, see https://github.com/impress-org/givewp/actions/runs/13461423181. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed QA tests
Resolves GIVE-2144
Description
This PR hooks into the page load to return a
404
for a Campaign Page when the campaign page feature is disabled on the campaign.Testing Instructions
Create a Campaign and edit the Campaign Page. Then disable the campaign page feature and try to load the Campaign Page as a site visitor.
Pre-review Checklist
@unreleased
tags included in DocBlocks