Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Campaign pages support titles #7713

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix: Campaign pages support titles #7713

merged 1 commit into from
Feb 17, 2025

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Feb 7, 2025 •
edited by jira bot
Loading

Resolves GIVE-2141

Description

This PR enables title support for Campaign Pages, which default to the title of the related Campaign.

Testing Instructions

Create a new Campaign and edit the Campaign Page.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Self Review of code and UX completed

@kjohnson kjohnson changed the base branch from develop to epic/campaigns February 7, 2025 15:28
@kjohnson kjohnson marked this pull request as ready for review February 7, 2025 15:30
jonwaldstein
jonwaldstein approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kjohnson
Copy link
Contributor Author

Build for QA, see https://github.com/impress-org/givewp/actions/runs/13334367736.

rickalday
rickalday approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 65ec8b9 into epic/campaigns Feb 17, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/campaign-page-title-GIVE-2141 branch February 17, 2025 21:14
@jonwaldstein jonwaldstein mentioned this pull request Feb 17, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjohnson @rickalday @jonwaldstein