Fix: Duplicated forms are assigned to the campaign of the original form #7712
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
changed the title
jonwaldstein
requested changes
Feb 7, 2025
| $campaign = $this->campaignRepository->queryByFormId($originalFormID)->get(); | ||
|
|
||
| try { | ||
| $this->campaignRepository->addCampaignForm($campaign, $duplicatedFormID, true); |
There was a problem hiding this comment.
Since $campaign is nullable, I would recommend checking if it exists first to avoid the potential of a fatal error from the typed param of addCampaignForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2140
Description
This PR hooks into the
give_form_duplicatedaction to assign the duplicated form to the campaign of the origional form.Testing Instructions
From the Campaign details on the forms tab, duplicate a form in the list table.
Pre-review Checklist
@unreleasedtags included in DocBlocks