Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Campaign List Block #7708

Merged
merged 85 commits into from
Feb 17, 2025
Merged

Feature: Campaign List Block #7708

merged 85 commits into from
Feb 17, 2025

Conversation

alaca
Copy link
Member

@alaca alaca commented Feb 5, 2025 •
edited by jonwaldstein
Loading

Description

This pull request introduces several new features and improvements to the campaign functionality, including the addition of a new block - campaign list, as well as adding a new component - Pagination

Visuals

image

https://www.loom.com/share/972c3025c71541b0b515a7db9fb06e3f?sid=8517fc4c-6942-4f3c-8bbc-240e1cefc087

Testing Instructions

Create at least 2 or 3 campaigns (make sure they are published)
To test sorting by donors, amount, and donations, make a few random donations through campaign forms
Create a new page/post or edit an existing one
Insert Campaign List Block into the page
Play with block settings
Verify that everything works on frontend too

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

alaca added 27 commits January 22, 2025 17:56
@alaca
initial commit
f7b29b7
@alaca
feature: render block
9c6d894
@alaca
feature: add icon and btn
088e26e
@alaca
feature: add description and hide select component if default form is…
673c59d 
… selected
@alaca
chore: add unreleased tags
76ead3f
@alaca
refactor: move campaign forms fetching logic outside the useCampaign …
572a377 
…hook
@alaca
initial commit
f66d535
@alaca
refactor: remove unused attributes
298b35b
@alaca
feature: add helper functions for displaying goal values and description
9385381
@alaca
refactor: add goalStats prop
7f1a040
@alaca
refactor: use CampaignGoalData instead of CampaignDonationQuery for g…
6859f65 
…oal stats
@alaca
refactor: use the new goalStats prop
86ee2a8
@alaca
feature: add goalStats props
5034344
@alaca
feature: render block
069c39d
@alaca
fix: missing campaign goal stats
15f0721
@alaca
Merge branch 'refs/heads/epic/campaigns' into feature/campaign-goal-b…
92e51e3 
…lock-GIVE-1510

# Conflicts:
#	src/Campaigns/Blocks/blocks.ts
@alaca
feature: add text control with goal description
ca7d6c9
@alaca
refactor: fix undefined campaign goalStats; use campaign method to ge…
0c163b7 
…t stats
@alaca
Merge branch 'refs/heads/epic/campaigns' into feature/campaign-goal-b…
3a49194 
…lock-GIVE-1510

# Conflicts:
#	src/Campaigns/Blocks/blocks.ts
#	src/Campaigns/Controllers/CampaignRequestController.php
@alaca
feature: set language using navigator object
e2cd894
@alaca
refactor: render block using ssr
0926bad
@alaca
initial commit
48ef08e
@alaca
refactor: update attributes
e7a2222
@alaca
refactor: use GridLayout component
2ab7961
@alaca
feature: add GridLayout component
05db9ef
@alaca
refactor: remove defaultValue param
4089d05
@alaca
feature: add per page and show pagination controls
298512f
@alaca alaca marked this pull request as draft February 5, 2025 11:34
@jonwaldstein jonwaldstein changed the base branch from epic/campaigns to feature/campaign-goal-block-GIVE-1510 February 13, 2025 14:47
jonwaldstein
jonwaldstein requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alaca looking good! just had a few suggestions. One thing we might have overlooked during the design review is the name of this block, I think it should actually be "Campaign Grid" as the successor to the Form Grid

jonwaldstein
jonwaldstein approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little typo left, otherwise Great job!

@alaca alaca changed the base branch from feature/campaign-goal-block-GIVE-1510 to epic/campaigns February 14, 2025 06:18
alaca added 7 commits February 14, 2025 07:50
@alaca
refactor: getCampaignDetailsWindowData
da65f7d
@alaca
refactor: remove leftover
eca6853
@alaca
refactor: use data attribute instead of class
b85d99b
@alaca
refactor: use givewp instead of give
376eba2
@alaca
Merge branch 'refs/heads/feature/campaign-goal-block-GIVE-1510' into …
bbd8622 
…feature/campaig-list-block-GIVE-1389
@alaca
fix: missing comma
8aa33aa
@alaca
Merge branch 'refs/heads/epic/campaigns' into feature/campaig-list-bl…
84c46ed 
…ock-GIVE-1389

# Conflicts:
#	src/Campaigns/Blocks/CampaignGoal/index.tsx
#	src/Campaigns/Blocks/blocks.ts
#	src/Campaigns/Controllers/CampaignRequestController.php
#	wordpress-scripts-webpack.config.js
rickalday
rickalday approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@jonwaldstein jonwaldstein merged commit f9244ae into epic/campaigns Feb 17, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/campaig-list-block-GIVE-1389 branch February 17, 2025 21:07
@jonwaldstein jonwaldstein mentioned this pull request Feb 17, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaca @rickalday @jonwaldstein