Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Register campaign theme color settings #7707

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Feb 4, 2025

Resolves GIVE-1385

Description

This Pull Request introduces new fields in Campaign Settings for setting Theme Colors, which will be used in related UI elements such as Campaign Donations, Campaign Donors, and Campaign Donate Button blocks.

It is important to note that colors must be applied individually to each block, as each block renders in a different Campaign context.

Affects

Campaign Settings page

Visuals

CleanShot 2025-02-12 at 22 12 01
Theme Color Settings

CleanShot 2025-02-12 at 22 12 51
Sample of color being applied to a campaign block

Testing Instructions

  • Go to the Campaign Settings tab
  • Set theme colors for that campaign
  • Edit the campaign page, adding some campaign specific blocks like Campaign Donors, Campaign Donations and Donate Button blocks
  • See how those blocks follow the color selected in the Campaign Settings

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski force-pushed the feature/campaign-theme-colors branch from 03c9a44 to 7ac95f9 Compare February 6, 2025 19:50
@pauloiankoski pauloiankoski force-pushed the feature/campaign-theme-colors branch from 7ac95f9 to 3b1d803 Compare February 13, 2025 01:03
@pauloiankoski pauloiankoski marked this pull request as ready for review February 13, 2025 01:17
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one minor thing that should be addressed. Other than that, good job man!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@pauloiankoski pauloiankoski merged commit 9980846 into epic/campaigns Feb 13, 2025
20 checks passed
@pauloiankoski pauloiankoski deleted the feature/campaign-theme-colors branch February 13, 2025 15:58
@jonwaldstein jonwaldstein mentioned this pull request Feb 17, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants