Skip to content

Commit

Permalink
refactor: revert position of sanitization
Browse files Browse the repository at this point in the history
  • Loading branch information
Jon Waldstein committed Feb 3, 2025
1 parent 6315788 commit 3c214e4
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions includes/formatting.php
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,6 @@ function give_get_cache_key($action, $query_args)
* Clean variables using sanitize_text_field. Arrays are cleaned recursively.
* Non-scalar values are ignored.
*
* @unreleased sanitize data before checking for serialized data
* @since 3.19.3 Don't unserialize data by default and return an empty string when data is serialized and $allow_serialized_data is false
* @since 3.17.2 Safe unserialize data by default
* @since 1.8
Expand All @@ -750,15 +749,11 @@ function give_clean($var, $allow_serialized_data = false)
return array_map('give_clean', $var);
}

if (is_scalar($var)) {
$var = sanitize_text_field(wp_unslash($var));
}

if ( Utils::isSerialized($var)) {
$var = $allow_serialized_data ? Utils::safeUnserialize($var) : '';
}

return $var;
return is_scalar($var) ? sanitize_text_field(wp_unslash($var)) : $var;
}

/**
Expand Down

0 comments on commit 3c214e4

Please sign in to comment.