Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): album count does not account for assets without exif #17150

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Mar 26, 2025

Fixes #15824

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue where the album count did not include assets that lack corresponding EXIF data by changing the join type from an inner join to a left join.

  • Changed the join on the "exif" table from innerJoin to leftJoin in album.repository.ts
Files not reviewed (1)
  • server/src/queries/album.repository.sql: Language not supported
Comments suppressed due to low confidence (1)

server/src/repositories/album.repository.ts:71

  • Switching to a left join correctly permits assets without exif data to be included; please ensure that any subsequent operations or conditions handling exif data properly account for potential null values.
.leftJoin('exif', 'assets.id', 'exif.assetId')

@alextran1502 alextran1502 changed the title fix(server): album count does not account for assets without exif" fix(server): album count does not account for assets without exif Mar 27, 2025
@alextran1502 alextran1502 merged commit fecf380 into main Mar 27, 2025
49 of 50 checks passed
@alextran1502 alextran1502 deleted the fix-15824 branch March 27, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Album missing, sync error
2 participants