Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shrink header on small screens #16909

Merged
merged 11 commits into from
Mar 24, 2025

Conversation

midzelis
Copy link
Contributor

Description

Responsive header - reduce size of header by 10px on small screens.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasm91 jrasm91 changed the title feat(web): shrink header on small screens feat: shrink header on small screens Mar 18, 2025
@midzelis midzelis force-pushed the mobile_responsive_header branch from 26aeb8e to 5342297 Compare March 19, 2025 03:44
@alextran1502
Copy link
Contributor

main pr
image image

I think the size on main is nice on a smaller screen, so your finger can actually tap on it, and they look more uniform

@midzelis
Copy link
Contributor Author

main pr
image image

|

Take a look:

  • I made all the icons consistent (they were a mix of medium/large before, now they are all medium) - we could make them all large if you prefer
  • Reduced header height another 4px
  • Made the logo a bit bigger (matching the avatar logo on the right)

Here it is with all large icons
image

@midzelis midzelis requested a review from alextran1502 March 24, 2025 03:44
@alextran1502 alextran1502 merged commit 0405a36 into mobile_longpress Mar 24, 2025
34 checks passed
@alextran1502 alextran1502 deleted the mobile_responsive_header branch March 24, 2025 15:08
alextran1502 added a commit that referenced this pull request Mar 24, 2025
* feat(web): max grid row height responsive

* also gallery-viewer

* lint

* feat(web): support long-press selection on mobile web

* use svelte-gestures

* fix test

* Bug fix

* globalThis

* format

* revert generator

* Testing

* bad merge

* Fix typo/tap on thumbnail

* feat: shrink header on small screens (#16909)

* feat(web): shrink header on small screens

* fix test

* test

* Fix test

* Revert user-page-layout chagne

* Restore icons sizes, make consistent, improve logo responsiveness

* remove 4 more pix, lint

* lint

* chore

---------

Co-authored-by: Alex Tran <[email protected]>

* Revert "Testing"

This reverts commit 442f11c.

---------

Co-authored-by: Alex Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants